osd: os/FileJournal: Fix journal write fail, align for direct io #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when config journal_zero_on_create true, osd mkfs will fail when zeroing journal. journal open with O_DIRECT, buf should align with blocksize. Backport: giant, firefly, dumpling Signed-off-by: Xie Rui <875016668@qq.com> Reviewed-by: Sage Weil <sage@redhat.com> (cherry picked from commit 80473f6)
|
What is the corresponding issue ? There does not seem to be a matching pull request for the cherry picked commit. |
ghost
self-assigned this
|
@smithfarm reading the comment helps... sorry for the noise ;-) |
|
@dachary Actually, I created the issue and added it to the comment :-) |
|
@dachary, is this ready to go? |
|
@dmick @smithfarm knows how much testing it saw. |
|
@dmick I would not say it is ready yet. It was in the last round of firefly integration tests. The rados suite results are here: http://tracker.ceph.com/issues/11644#note-102 I am scheduling suites for a new round, now. |
|
New rados suite: http://tracker.ceph.com/issues/11644#note-110 |
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
…gn for direct io Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
os/FileJournal: Fix journal write fail, align for direct io Reviewed-by: Loic Dachary <ldachary@redhat.com> Reviewed-by: Nathan Cutler <ncutler@suse.cz>
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12945