New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow journal aio_lock locking scope in write_aio_bl #5670
Conversation
Aio io_submit in write_aio_bl with aio_lock might take long time to return, so write_finish_thread_entry can't process completed aio when io_submit is blocking. Try to narrow aio_lock locking scope to help those completed aio to get processed asap. Signed-off-by: Zhi Zhang zhangz.david@outlook.com
Haomai, can you pls take a look or schedule some one to do? Thanks. |
LGTM |
Sorry, can you be more specific on avoiding extra new at line 1414? |
never mind, it's ok for this PR to reduce lock scope |
thanks. |
LGTM |
osd: FileJournal: reduce locking scope in write_aio_bl Reviewed-by: Haomai Wang <haomai@xsky.com>
Aio io_submit in write_aio_bl with aio_lock might take long time to return, so write_finish_thread_entry can't process completed aio when io_submit is blocking. Try to narrow aio_lock locking scope to help those completed aio to get processed asap.
Fixes: #12789
Signed-off-by: Zhi Zhang zhangz.david@outlook.com