rbd: crash during shutdown after writeback blocked by IO errors #5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
…ed by IO errors Reviewed-by: Loic Dachary <ldachary@redhat.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit 540346d)
Now the judgement only in conditon which will return -ENOENT. But o->exists don't depend on the extent size. It only depend on trust_enoent. So move this judgement at the first of _readx(). Make this bug ASAP occur. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit 2449fdd)
Avoid wakeup early and wait again. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit d582bda)
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit 1a48a8a)
Because the mutex is the same as ObjectCacher::lock. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit d7cf7ae)
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit 9f80c29)
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit 101440a)
If bh_write met error, it will try again. For closing image, if met this issue, it will trigger a assert: >>2015-02-03 15:22:49.198292 7ff62d537800 -1 osdc/ObjectCacher.cc: In function 'ObjectCacher::~ObjectCacher()' thread 7ff62d537800 time >>2015-02-03 15:22:49.195927osdc/ObjectCacher.cc: 551: FAILED >>assert(i->empty()) Now add purge_on_error, when shutdown_cache it set true. In ImageCtx::invalidate_cache, if met error and purge_on_error is true, purge the dirty bh. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit 35def5c) Conflicts: src/librbd/ImageCtx.cc : trivial resolution
|
@dillaman this hammer backport passed the rbd suite (see http://tracker.ceph.com/issues/12701#note-61 for details). Do you think it is ready to be merged ? Note the trivial conflict resolution at 6c4ccc8, the rest cherry-pick cleanly. |
|
LGTM |
ghost
pushed a commit
that referenced
this pull request
Sep 13, 2015
Crash during shutdown after writeback blocked by IO errors Reviewed-by: Jason Dillaman <dillaman@redhat.com>
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12597