hammer: osd: ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov is there an upgrade test that verifies the gmt feature ? I guess what we want is to check that hammer-x with this patch in hammer will upgrade well to infernalis. |
ghost
changed the title
|
@dachary i am testing the upgrade test at http://pulpito.ceph.com/kchai-2015-09-06_03:41:25-upgrade:hammer-x-master---basic-vps/ . will update this pr with the test result. |
|
@dachary the test passed. but the test was designed so that hammer without bitwise sort and gmt fix can be upgraded to specified branch (with sortbitwise and gmt fix). i will remove following code and post a pull request (ceph/ceph-qa-suite#554) to ceph-qa-suite/master ceph set pool set cache-pool use_gmt_hitset true 2>&1 | grep "not all OSDs support GMT hit set"after this pr is merged. if hammer branch supports gmt hitset, the hitset archives will be upgraded to infernalis naturally. i will also prepare a test for firefly => hammer upgrade as suggested by @athanatos at http://tracker.ceph.com/issues/9732#note-11 . |
|
@tchaikov that makes sense, thanks for the detailed explanation :-) |
|
the tests is posted at ceph/ceph-qa-suite#554 |
tchaikov
changed the title
|
please hold until #5837 is merged. and then we will backport that pr, and put it into this one. |
tchaikov
changed the title
|
added the backport from #5837 |
tchaikov
force-pushed
the
wip-12848-hammer
branch
from
99d3bed
to
965b4eb
Compare
|
rebased against ceph.git/hammer, and pushed to ceph.git/wip-12848-hammer to test using the upgrade test suite |
tchaikov
force-pushed
the
wip-12848-hammer
branch
from
965b4eb
to
3d4116f
Compare
ghost
changed the title
ghost
removed their assignment
|
@tchaikov ack :-) |
* bump the encoding version of pg_hit_set_info_t to 2, so we can tell if the corresponding hit_set is named using localtime or GMT * bump the encoding version of pg_pool_t to 20, so we can know if a pool is using GMT to name the hit_set archive or not. and we can tell if current cluster allows OSDs not support GMT mode or not. * add an option named `osd_pool_use_gmt_hitset`. if enabled, the cluster will try to use GMT mode when creating a new pool if all the the up OSDs support GMT mode. if any of the pools in the cluster is using GMT mode, then only OSDs supporting GMT mode are allowed to join the cluster. Fixes: ceph#9732 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 42f8c5d) Conflicts: src/include/ceph_features.h src/osd/ReplicatedPG.cc src/osd/osd_types.cc src/osd/osd_types.h fill pg_pool_t with default settings in master branch.
Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit cc2bcf7) Conflicts: src/mon/OSDMonitor.cc use the old way to dump pool info
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 2bc5a48) Conflicts: src/osd/osd_types.cc minor changes to resolve conflicts
* to ease the backport to hammer Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 5a4f6a8) Conflicts: src/include/ceph_features.h minor changes to resolve conflicts
the gmt_hitset is enabled by default in the ctor of pg_pool_t, this is intentional. because we want to remove this setting and make gmt_hitset=true as a default in future. but this forces us to disable it explicitly when preparing a new pool if any OSD does not support gmt hitset. Fixes: ceph#12968 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit e48cec3) Conflicts: src/mon/OSDMonitor.cc remove unrelated hunk
When hit set is not configured on startup or on a change, remove all previous hitsets. Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com> (cherry picked from commit be28319) Conflicts: src/osd/ReplicatedPG.cc pass the new argument of `p->using_gmt` to get_hit_set_archive_object()
Only the primary PG is allowed to remove all the hit set objects. And the PG should be in the active or peered states. Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com> (cherry picked from commit fd38902)
Otherwise impl is unpopulated and we risk segfaults in several methods. It also seems like it would always indicate a bug. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 8e5a801)
tchaikov
force-pushed
the
wip-12848-hammer
branch
from
3d4116f
to
6a4734a
Compare
tchaikov
changed the title
ghost
pushed a commit
that referenced
this pull request
Nov 10, 2015
ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Nov 17, 2015
ReplicatedPG::hit_set_trim osd/ReplicatedPG.cc: 11006: FAILED assert(obc) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
mentioned this pull request
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12848
http://tracker.ceph.com/issues/13288