common: Pipe: Drop connect_seq increase line #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert commit 0fc47e2. When accepting and "connect.connect_seq == existing->connect_seq", existing->state maybe STATE_OPEN, STATE_STANDBY or STANDY_CONNECTING. This commit only fix partial problem and want to assert "(existing->state == STATE_CONNECTING)". So later we added codes to catch "(existing->state == STATE_OPEN || existing->state == STATE_STANDBY)" before asserting. Backport: dumpling, firefly, giant Signed-off-by: Haomai Wang <haomaiwang@gmail.com> (cherry picked from commit 67225cb)
|
I'm hoping this is responsible for the ping failures i'm seeing on hammer->infernalis upgrade tests |
ghost
pushed a commit
that referenced
this pull request
Sep 14, 2015
Pipe: Drop connect_seq increase line Reviewed-by: Greg Farnum <gfarnum@redhat.com>
ghost
merged commit 
|
Is there an issue associated with this problem ? |
ghost
changed the title
ghost
self-assigned this
|
Searching my email the answer seems to be "no", sorry. :/ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13094