Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hammer: rgw: backport content-type casing #5910

Merged
1 commit merged into from Dec 2, 2015
Merged

hammer: rgw: backport content-type casing #5910

1 commit merged into from Dec 2, 2015

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2015

Addresses: http://tracker.ceph.com/issues/13047

Since #5718 was recently merged into hammer (improving the
surrouding content-type code) it appears now is a good time to backport the content-type casing
fix.

@smithfarm smithfarm added this to the hammer milestone Sep 13, 2015
@smithfarm smithfarm assigned ghost Sep 13, 2015
@smithfarm smithfarm changed the title backport content-type casing [DNM] rgw: backport content-type casing Sep 13, 2015
@smithfarm
Copy link
Contributor

I put [DNM] (Do Not Merge) because this PR needs to be reconciled with #5718

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/7739/

@smithfarm
Copy link
Contributor

@kmroz: the make check bot likes your PR :-)

@ghost
Copy link
Author

ghost commented Sep 14, 2015

@smithfarm a good start ;)

@smithfarm
Copy link
Contributor

@kmroz: In the PR description you listed the original issues that were fixed in master, but for hammer we need the hammer backport tracker numbers instead:

http://tracker.ceph.com/issues/12859
http://tracker.ceph.com/issues/12634
http://tracker.ceph.com/issues/13047
http://tracker.ceph.com/issues/12632

Please update the description.

@smithfarm
Copy link
Contributor

Once #5718 is merged, this backport will get a lot simpler :-)

@ghost
Copy link
Author

ghost commented Sep 14, 2015

@smithfarm Will update the tracker numbers after #5718 merge. Thanks for the heads up.

@smithfarm
Copy link
Contributor

@kmroz: #5718 has been merged.

@kmroz
Fix casing of Content-Type header
db1cbe7 
It turns out, despite the HTTP spec declaring that header field names
should be case-insensitive, some clients treat them wrongly, and
consider "Content-type" to not match "Content-Type".

CyberDuck was one of those clients, now fixed upstream in
https://trac.cyberduck.io/ticket/8999

To reduce future occurances of this bug, fix the casing of the
Content-Type header, to strictly comply with the HTTP specification (be
strict about what you send, and generous about what you receive).

Fixes: #12939
Backport: infernalis, hammer, firefly
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
(cherry picked from commit 1b9fbff)
@ghost
Copy link
Author

ghost commented Oct 27, 2015

Perfect. I've checked #5718 and it contains the rgw commits that I originally tried to backport along with the casing fix in the above commit.

@smithfarm - can we trigger the testsuite to re-run on this PR?

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8689/

@ghost
Copy link
Author

ghost commented Oct 28, 2015

Looks that @loic-bot is all over it ;)

@smithfarm smithfarm changed the title [DNM] rgw: backport content-type casing rgw: backport content-type casing Oct 28, 2015
ghost pushed a commit that referenced this pull request Nov 11, 2015
Merge pull request #5910: rgw: backport content-type casing
b623d58 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 13, 2015
Merge pull request #5910: rgw: backport content-type casing
e5b0456 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 13, 2015
Merge pull request #5910: rgw: backport content-type casing
25d91be 
Reviewed-by:
ghost pushed a commit that referenced this pull request Nov 16, 2015
Merge pull request #5910: rgw: backport content-type casing
ab0cf7d 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Nov 16, 2015

@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-23 ).

ghost pushed a commit that referenced this pull request Nov 19, 2015
Merge pull request #5910: rgw: backport content-type casing
f516aaf 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
Merge pull request #5910: rgw: backport content-type casing
42f59b1 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
Merge pull request #5910: rgw: backport content-type casing
55557e6 
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost assigned yehudasa and unassigned ghost Nov 21, 2015
@ghost
Copy link

ghost commented Nov 25, 2015

@yehudasa ping ?

@yehudasa
Copy link
Member

yehudasa commented Dec 2, 2015

@dachary lgtm

ghost pushed a commit that referenced this pull request Dec 2, 2015
Merge pull request #5910 from kmroz/wip-hammer-backport-content-type
36e4db3 
rgw: backport content-type casing

Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>
@ghost ghost merged commit 36e4db3 into ceph:hammer Dec 2, 2015
@ghost ghost changed the title rgw: backport content-type casing hammer: rgw: backport content-type casing Feb 18, 2016
@ghost ghost deleted the wip-hammer-backport-content-type branch March 17, 2016 10:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yehudasa yehudasa

Labels
bug-fix rgw
Projects
None yet
Milestone
hammer
3 participants
@smithfarm @loic-bot @yehudasa