New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: modify documents and help infos' descriptions to the usage of option date when executing command "log show" #6080
Conversation
…tion date when executing command "log show" DOCUMENTATION ceph#13235 This modification concerns documents and help infos. To the documents, we delete original incorrect instruction about the usage of the option date which induces user to type the value of date in the format of "YYYY-MM-DD" when executing "log show" command, and we add the actual usage of "YYYY-MM-DD-hh". To the help infos, we add the NOTE to make user notice that the usage of option date here is different with default's and of cource we give the right formatting. Signed-off-by: Kongming Wu <wu.kongming@h3c.com>
7420393
to
6160b3c
Compare
6160b3c
to
1aaad6d
Compare
1aaad6d
to
0d5aa24
Compare
0d5aa24
to
bffeb5f
Compare
Requiring the user to type YYYY-MM-DD-HH seems odd. If that is really required, I wonder if it is a bug that should be fixed instead of adapting the documentation to it. |
Also note that this does not pass "make check" (see bot failures, above - especially the "Console log" therein). It cannot be merged until that passes. |
@smithfarm I added this PR in Sept. and this Issue is existed. i.e. '-HH' (hour) must be appended.What weird is why loic-bot compiled failed, cause this part of codes does not change and I compiled successfully in local. |
@smithfarm log searching has its inside mechanism, which parameter 'YYYY-MM-DD-HH' will be transfered into timestamp as a key word. I try to repushed changes, now, this is not what i want to submit. |
bffeb5f
to
8884363
Compare
8884363
to
f93fef1
Compare
f93fef1
to
23d8a34
Compare
@clever215 I'm not familiar with the
|
@smithfarm yeah, I see. radosgw-admin.cc and help.t are not in the same format that cause this failing.I try to fix it. Sorry about that! |
@smithfarm It's OK now! |
@smithfarm I wish it will be merged soon. Cause these notes mislead users for a long time.Happy weekends! |
@smithfarm Hi, How's that, I means this change? |
@yehudasa How do you think about this issue? |
rgw: modify documents and help infos' descriptions to the usage of option date when executing command "log show" Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
DOCUMENTATION #13235
This modification concerns documents and help infos. To the documents, we delete original incorrect instruction about the usage of the option date which induces user to type the value of date in the format of "YYYY-MM-DD" when executing "log show" command, and we add the actual usage of "YYYY-MM-DD-hh". To the help infos, we add the NOTE to make user notice that the usage of option date here is different with default's and of cource we give the right formatting.
Signed-off-by: Kongming Wu wu.kongming@h3c.com