Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hammer: common: small probability sigabrt when setting rados_osd_op_timeout #6143

Merged
2 commits merged into from Nov 21, 2015
Merged

hammer: common: small probability sigabrt when setting rados_osd_op_timeout #6143

2 commits merged into from Nov 21, 2015

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2015

@ghost ghost self-assigned this Oct 2, 2015
@ghost ghost added this to the hammer milestone Oct 2, 2015
@ghost ghost added bug-fix core labels Oct 2, 2015
@loic-bot
Copy link

loic-bot commented Oct 2, 2015

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/8157/

ghost pushed a commit that referenced this pull request Oct 2, 2015
@ldachary
Merge pull request #6143: small probability sigabrt when setting rado…
f05391c 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
@ldachary
Merge pull request #6143: small probability sigabrt when setting rado…
6be444d 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
@ldachary
Merge pull request #6143: small probability sigabrt when setting rado…
1d3214c 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
@ldachary
Merge pull request #6143: small probability sigabrt when setting rado…
35f2d15 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 7, 2015
@ldachary
Merge pull request #6143: small probability sigabrt when setting rado…
384f156 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 8, 2015
@ldachary
Merge pull request #6143: small probability sigabrt when setting rado…
b0e7f15 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Nov 4, 2015

@liewegas does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-11 and for details ).

@liewegas
Copy link
Member

liewegas commented Nov 6, 2015

needs to be backported with 0635b13

otherwise, 👍

@ghost
Copy link
Author

ghost commented Nov 6, 2015

@liewegas good catch ! I failed to notice the issue was fixed by two pull requests, #6078 with 0635b13.

@yangruifeng @ldachary
Objecter: repeated free op->ontimeout.
84068f8 
repeated free op->ontimeout in SafeTimer::timer_thread::callback->complete

Fixes: #13208
Signed-off-by: Ruifeng Yang <yangruifeng.09209@h3c.com>
(cherry picked from commit f1d8a8f)
@yangruifeng @ldachary
Objecter: maybe access wild pointer(op) in _op_submit_with_budget.
394fbfc 
look at "after giving up session lock it can be freed at any time by response handler" in _op_submit,
so the _op_submit_with_budget::op maybe is wild after call _op_submit.

Fixes: #13208
Signed-off-by: Ruifeng Yang <yangruifeng.09209@h3c.com>
(cherry picked from commit 0635b13)
@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/9142/

ghost pushed a commit that referenced this pull request Nov 11, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
3adf0fa 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 13, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
2cfa3b9 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 13, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
ba2c3f6 
…s_osd_op_timeout

Reviewed-by:
ghost pushed a commit that referenced this pull request Nov 16, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
52cce8d 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
ee5fa56 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
8b9153b 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
Merge pull request #6143: small probability sigabrt when setting rado…
0e9d356 
…s_osd_op_timeout

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Nov 21, 2015

It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-28 for details ).

ghost pushed a commit that referenced this pull request Nov 21, 2015
Merge pull request #6143 from dachary/wip-13340-hammer
65aeba0 
small probability sigabrt when setting rados_osd_op_timeout

Reviewed-by: Sage Weil <sage@redhat.com>
@ghost ghost merged commit 65aeba0 into ceph:hammer Nov 21, 2015
@ghost ghost changed the title small probability sigabrt when setting rados_osd_op_timeout hammer: common: small probability sigabrt when setting rados_osd_op_timeout Feb 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix core
Projects
None yet
Milestone
hammer
3 participants
@loic-bot @liewegas @yangruifeng