tests: TEST_crush_rule_create_erasure consistently fails on i386 builder #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test that goes with f1e86be to verify that a bugous crush ruleset will prevent the creation of a pool trying to use it was fragile. I depends on the implementation of the erasure code lrc plugin and turns out to not work on i386. The test is modified to use a fake crushtool that always returns false and validate that it prevents the creation of a pool, which demonstrate it is used for crushmap validation prior to the pool creation. http://tracker.ceph.com/issues/12419 Fixes: #12419 Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit e479037)
|
I did not notice the test failed on i386 in hammer, this fixes it. |
|
verifying in the gitbuilders |
|
the gitbuilder builds look good: |
ghost
pushed a commit
that referenced
this pull request
Oct 9, 2015
TEST_crush_rule_create_erasure consistently fails on i386 builder Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13410