pybind: add ceph_volume_client interface for Manila and similar frameworks #6205
Conversation
|
Looks good to me. We just need to add this to ceph.spec.in and debian/* so that it goes in the python-ceph package |
| self.libcephfs = load_libcephfs() | ||
| self.cluster = c_void_p() | ||
|
|
||
| self.state = "uninitialized" | ||
| if rados_inst is not None: | ||
| return self.create_with_rados(rados_inst) |
There was a problem hiding this comment.
Should probably check here that the caller hasn't filled in the auth_id (and possibly the conf/conffile) since we're ignoring it in favor of the existing rados inst.
|
I know you're doing stuff with this for Manila, but we should get something that tests it in the nightlies too. |
|
Related test PR: ceph/ceph-qa-suite#680 |
jcsp
changed the title
jcsp
force-pushed
the
wip-volume-client
branch
from
74e76b7
to
372920c
Compare
|
ping @gregsfortytwo any outstanding issues? |
|
Nothing I know of. Need to check tests (which are still not passing linter, looks like). |
|
Looks like the test failed in my integration branch. I doubt anything else there is causing issues for this: http://pulpito.ceph.com/ubuntu-2015-11-24_12:55:44-fs-greg-fs-verify---basic-multi/1158617/ |
jcsp
force-pushed
the
wip-volume-client
branch
from
6260135
to
2da97e0
Compare
For those folks who aren't running as 'admin'. We already allow this at the C layer, it was just left out of the python binding. Signed-off-by: John Spray <john.spray@redhat.com>
Things got weird (tcmalloc exceptions) if one used both libraries from the same process, presumably because of some of these dependencies. Signed-off-by: John Spray <john.spray@redhat.com>
Enable setting up cephfs while borrowing the CephContext from an already-set-up rados python client. Signed-off-by: John Spray <john.spray@redhat.com>
This is for applications that want to use librados and libcephfs in the same process, without trying to have two CephContexts Signed-off-by: John Spray <john.spray@redhat.com>
This is for FSaaS interfaces like Manila. Signed-off-by: John Spray <john.spray@redhat.com>
Tests for VolumeClient will use this. Signed-off-by: John Spray <john.spray@redhat.com>
Signed-off-by: John Spray <john.spray@redhat.com>
Generalize authorization so that an ID can be authorized for multiple shares. Remove commented blocks. Separate purge from delete. Up to the caller to background the purge part. Signed-off-by: John Spray <john.spray@redhat.com>
Signed-off-by: John Spray <john.spray@redhat.com>
Signed-off-by: John Spray <john.spray@redhat.com>
Signed-off-by: John Spray <john.spray@redhat.com>
Don't try waiting on empty context gatherbuilder. Signed-off-by: John Spray <john.spray@redhat.com>
Signed-off-by: John Spray <john.spray@redhat.com>
jcsp
force-pushed
the
wip-volume-client
branch
from
2da97e0
to
9d10efb
Compare
|
Passing happily now with no breakage to other stuff that I can see: http://pulpito.ceph.com/jspray-2016-01-07_15:02:38-fs-wip-jcsp-testing---basic-smithi/17155 |
…reg-fs-speculative #6205
|
Still passing: http://pulpito.ceph.com/gregf-2016-01-12_23:29:42-fs-greg-fs-speculative---basic-mira/26611 @gregsfortytwo any objections to merging? |
|
Need to ID new failures in that integration branch but I hope to click the button. |
|
Here's another passing run. Only non-green jobs are ones that didn't get nodes in time (5) or one that couldn't download apt key (1). http://pulpito.ceph.com/jspray-2016-01-15_02:26:10-fs-wip-volume-client---basic-mira/ |
…reg-fs-testing #6205 Reviewed-by: Greg Farnum <gfarnum@redhat.com>
…reg-fs-testing #6205 Reviewed-by: Greg Farnum <gfarnum@redhat.com>
pybind: add ceph_volume_client interface for Manila and similar frameworks Reviewed-by: Greg Farnum <gfarnum@redhat.com>
No description provided.