Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG: pg down state blocked by osd.x, lost osd.x cannot solve peering stuck #6317

Merged
merged 1 commit into from Mar 29, 2016

Conversation

cxwshawn
Copy link

Fixes #13531

@cxwshawn cxwshawn force-pushed the wip-lost-fix branch 2 times, most recently from fa84eac to d99b74b Compare October 20, 2015 03:51
…tuck.

Fixes ceph#13531

Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
@athanatos
Copy link
Contributor

This looks right to me, we need to write a teuthology test to go in with this fix, and we need to run it through testing.

@cxwshawn
Copy link
Author

@athanatos hmm, actually I don't really know how to add test about this modification, so give some hint, so I can know how we will do next.

@athanatos
Copy link
Contributor

You can ask in #ceph-devel for help, but it's the ceph-qa-suite git project. We have ways of running the tests on openstack clusters now.

@athanatos
Copy link
Contributor

https://github.com/ceph/ceph-qa-suite/blob/master/tasks/lost_unfound.py is a test which tests lost_unfound handling (for example).

@tchaikov
Copy link
Contributor

tchaikov commented Nov 4, 2015

@cxwshawn, you could join the #ceph-devel channel (see http://ceph.com/resources/mailing-list-irc/ ) to learn more about how to write a test for your change. ping me if you need more help. and you can setup a testbed in minutes by following https://github.com/ceph/teuthology#openstack-backend. teuthology is the infrastructure driving the tests in ceph-qa-suites.

@tchaikov
Copy link
Contributor

@cxwshawn ping?

@cxwshawn
Copy link
Author

@tchaikov sorry, busy for other things lately, can u help me ?

@tchaikov
Copy link
Contributor

@cxwshawn, you can start with https://github.com/ceph/ceph-qa-suite/blob/master/erasure-code/ec-feature-plugins-v3.yaml, by reading yaml you can learn how to start/restart/stop a daemon, and create a test suite in "suites/rados/singleton/all/" (@athanatos do you think there is a better place for this test?), like:

roles:
- - mon.a
  - osd.0
  - osd.1
  - osd.2
- - client.0
tasks:
- install:
- ceph:
    log-whitelist:
    - objects unfound and apparently lost
- exec:
   client.0:
    - rados -p rbd put foo /etc/hosts
# more to come

ping me over irc if you want to learn more about teuthology and its tests =)

@liewegas
Copy link
Member

@cxwshawn ping

@athanatos athanatos merged commit d2beb77 into ceph:master Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants