Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: build/ops: LTTng-UST tracing should be dynamically enabled #6415

Merged
10 commits merged into from Jan 14, 2016

Conversation

dillaman
Copy link

@dillaman dillaman added this to the hammer milestone Oct 28, 2015
@dillaman
Copy link
Author

@ktdreyer Can you double-check my backport changes to your commit @ 62b40f0

@ghost ghost self-assigned this Nov 4, 2015
@ghost
Copy link

ghost commented Nov 4, 2015

@ktdreyer it should be -2

@dillaman
Copy link
Author

dillaman commented Nov 4, 2015

@dachary @ktdreyer updated to -2

@ktdreyer
Copy link
Member

ktdreyer commented Nov 4, 2015

Thanks, LGTM

@ghost ghost changed the title LTTng-UST tracing should be dynamically enabled DNM: LTTng-UST tracing should be dynamically enabled Nov 10, 2015
@ghost
Copy link

ghost commented Nov 10, 2015

DNM until #5790 is merged because it conflicts with it

@ghost
Copy link

ghost commented Nov 19, 2015

@dillaman could you please rebase & repush & remove the DNM prefix when you do ?

@ghost ghost assigned dillaman and unassigned ghost Nov 19, 2015
@dillaman dillaman closed this Nov 20, 2015
Jason Dillaman added 10 commits November 20, 2015 11:48
LTTng-UST initializes itself at program load, which means it is
currently always enabled.  This can lead to issues with SElinux
and AppArmor which might restrict access to the necessary device
files.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 4a5305e)

 Conflicts:
	src/test/Makefile-client.am: trivial resolution
	src/tracing/Makefile.am: trivial resolution
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit f4feee2)

 Conflicts:
	ceph.spec.in: trivial resolution
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit a7ed8e1)
The TracepointProvider class is a configuration observer.  When
tracing is enabled, it will dynamically load the associated
tracepoint provider.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit b3d02cc)

Conflicts:
	src/common/Makefile.am: trivial resolution
This results in the tracepoint provider shared libraries being
placed in the library path for unittests.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit e11d8d6)

Conflicts:
	configure.ac: trivial resolution
	src/Makefile.am: trivial resolution
Config options to enable LTTng-UST tracepoint providers for
the OSD, OSD objectstore, librados, and librbd.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 2ccef89)

Conflicts:
	src/common/config_opts.h: trivial resolution
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 1a6eea9)

Conflicts:
	src/librbd/librbd.cc: trivial resolution
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 6368c28)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 0009f34)
It was previously assumed that a CephContext singleton would
inherit from CephContext::AssociatedSingletonObject, but it was
not enforced.  This could result in unknown behavior when the
singleton is destroyed due to the implied virtual destructor.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit fb62c78)
@dillaman
Copy link
Author

rebase wiped out all the commit somehow. fixed and reopening.

@dillaman dillaman reopened this Nov 20, 2015
@dillaman dillaman changed the title DNM: LTTng-UST tracing should be dynamically enabled LTTng-UST tracing should be dynamically enabled Nov 20, 2015
@dillaman dillaman assigned ghost and unassigned dillaman Nov 20, 2015
ghost pushed a commit that referenced this pull request Jan 11, 2016
…bled

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Jan 11, 2016
…bled

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Jan 11, 2016
…bled

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Jan 14, 2016

passed (all but one) rbd suite http://tracker.ceph.com/issues/13356#note-35

ghost pushed a commit that referenced this pull request Jan 14, 2016
LTTng-UST tracing should be dynamically enabled

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit 0ca6285 into ceph:hammer Jan 14, 2016
@dillaman
Copy link
Author

Fix in-progress for broken precise and wheezy builds.

@ghost ghost changed the title LTTng-UST tracing should be dynamically enabled hammer: build/ops: LTTng-UST tracing should be dynamically enabled Feb 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants