MOSDRepOp/ MOSDRepOpReply: Simple Messenger optimization #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +70,7 @@ | |||
| #define CEPH_FEATURE_OSD_HITSET_GMT (1ULL<<54) | |||
| #define CEPH_FEATURE_HAMMER_0_94_4 (1ULL<<55) | |||
| #define CEPH_FEATURE_NEW_OSDOP_ENCODING (1ULL<<56) /* New, v7 encoding */ | |||
| #define CEPH_FEATURE_NEW_OSDREPOP_ENCODING (1ULL<<57) /* New, v2 encoding */ | |||
There was a problem hiding this comment.
@liewegas Is it possible to make this feature combined with 56? I guess it should be timely
There was a problem hiding this comment.
If this goes in quickly, yes...
XinzeChi
force-pushed
the
wip-repop-worker
branch
from
c8070d4
to
22d2732
Compare
liewegas
added a commit
that referenced
this pull request
Nov 28, 2015
osd: defer decoding of MOSDRepOp/MOSDRepOpReply Reviewed-by: Haomai Wang <haomai@xsky.com> Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the origin idea is from #5211
This PR is happy when cpu frequency is low, and the single pipe spend to much time on decode msg.
Signed-off-by: Xinze Chi xinze@xsky.com