librados: potential null pointer access in list_(n)objects #6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-13822
branch
from
c62754b
to
cda5c26
Compare
|
looks reasonable to me. can you please add a test to test/librados/list.cc ? |
|
lgtm also. agreed with sage. |
|
ping @xiexingguo ? |
|
This needs a test before merge. |
xiexingguo
force-pushed
the
xxg-wip-13822
branch
from
d4859ef
to
bef5bad
Compare
|
@xiexingguo could you please rebase on latest master? Thanks! |
xiexingguo
force-pushed
the
xxg-wip-13822
branch
from
bef5bad
to
1908d32
Compare
In list_objects and list_nobjects, we are possibly access a null returned pointer from the osdmap->get_pg_pool() call. Fixes: ceph#13822 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@liewegas Rebased. Thank you for your reminder:)) |
liewegas
added a commit
that referenced
this pull request
Dec 31, 2015
librados: potential null pointer access in list_(n)objects Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In list_objects and list_nobjects, we are possibly access a null returned pointer from the osdmap->get_pg_pool() call.
Fixes: #13822
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn