Test:bencher wrong test margin casuses writes over object_size #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-changtao
changed the title
|
@jack-changtao the change looks good to me. but the Signed-off line does not look right: you might want to change it to if "Chang" is your first name. |
|
@tchaikov |
|
@jack-changtao use and you need a space after the colon: |
jack-changtao
force-pushed
the
test-bench
branch
from
80f0995
to
56da106
Compare
|
@tchaikov |
Signed-off-by: Tao Chang <changtao@hihuron.com>
Signed-off-by: Tao Chang <changtao@hihuron.com>
liewegas
added a commit
that referenced
this pull request
Dec 3, 2015
rados: bench: fix off-by-one to avoid writing past object_size Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tao Chang changtao@hihuron.com