Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysvinit: allow custom cluster names #6732

Merged
merged 1 commit into from Dec 11, 2015

Conversation

aalba6675
Copy link
Contributor

Squashed commit: improves #6726

Allows custom cluster names during system startup by emulating CLI.
In Red Hat (/etc/sysconfig/ceph) or Debian (/etc/default/ceph):

cluster=mycluster

is equivalent to /etc/init.d/ceph --cluster mycluster

conf=/etc/ceph/mycluster.conf
use_default_conf=0

is equivalent to --conf /etc/ceph/mycluster.conf

@tchaikov
Copy link
Contributor

tchaikov commented Dec 1, 2015

@aalba6675 you might want to prefix your commit message with "init-ceph: " or "init-ceph.in: ". and also add a "Signed-off-by" line at the end of the commit message, see https://github.com/ceph/ceph/blob/master/SubmittingPatches#L62 . more examples could be found using git log src/init-ceph.in

@liewegas liewegas changed the title Allow custom cluster names sysvinit: allow custom cluster names Dec 1, 2015
Signed-off-by: Richard Chan <richard@treeboxsolutions.com>
@aalba6675
Copy link
Contributor Author

Done - could you review the commit again.

Improved comment, added signed off from my collaborator.

@b-ranto
Copy link
Contributor

b-ranto commented Dec 2, 2015

Is there any tracker issue associated to this PR? I'd like to (propose to) see this PR backported to hammer -- I had a bug report regarding this for Fedora 22 (hammer inside).

@gregsfortytwo
Copy link
Member

I've got a related set of patches in wip-init-names that have been languishing since earlier this year — making sysvinit support multiple (named) clusters on a single host. The bit I ran into there is that we need to handle upgrading properly.
This patch is a little simpler (it's not touching the pid filenames) and so might work, but please check upgrades against it!

liewegas added a commit that referenced this pull request Dec 11, 2015
sysvinit: allow custom cluster names

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit df56dc9 into ceph:master Dec 11, 2015
@liewegas
Copy link
Member

@BRANTO1 There isn't a tracker issue (not really a bug). Mind just opening a PR with a cherry-pick -x against hammer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants