New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysvinit: allow custom cluster names #6732
Conversation
@aalba6675 you might want to prefix your commit message with "init-ceph: " or "init-ceph.in: ". and also add a "Signed-off-by" line at the end of the commit message, see https://github.com/ceph/ceph/blob/master/SubmittingPatches#L62 . more examples could be found using |
Signed-off-by: Richard Chan <richard@treeboxsolutions.com>
60bb1b6
to
13925c7
Compare
Done - could you review the commit again. Improved comment, added signed off from my collaborator. |
Is there any tracker issue associated to this PR? I'd like to (propose to) see this PR backported to hammer -- I had a bug report regarding this for Fedora 22 (hammer inside). |
I've got a related set of patches in wip-init-names that have been languishing since earlier this year — making sysvinit support multiple (named) clusters on a single host. The bit I ran into there is that we need to handle upgrading properly. |
sysvinit: allow custom cluster names Reviewed-by: Sage Weil <sage@redhat.com>
@BRANTO1 There isn't a tracker issue (not really a bug). Mind just opening a PR with a cherry-pick -x against hammer? |
Squashed commit: improves #6726
Allows custom cluster names during system startup by emulating CLI.
In Red Hat (/etc/sysconfig/ceph) or Debian (/etc/default/ceph):
is equivalent to /etc/init.d/ceph --cluster mycluster
is equivalent to --conf /etc/ceph/mycluster.conf