New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: signal_handler: added support for using reentrant strsignal() implementations vs. sys_siglist[] #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dx9
changed the title
signal_handler: fallback to strsignal when sys_siglist is not implemeted
signal_handler: fallback to strsignal when sys_siglist is not implemented
Dec 4, 2015
dx9
force-pushed
the
wip-12406-sys_siglist
branch
from
December 4, 2015 14:34
00b2b6b
to
39d5c45
Compare
The patch assumes that if sys_siglist does not exist strsignal() is safe. |
dx9
force-pushed
the
wip-12406-sys_siglist
branch
from
December 7, 2015 19:18
39d5c45
to
4cdf42d
Compare
dx9
changed the title
signal_handler: fallback to strsignal when sys_siglist is not implemented
signal_handler: added support for using reentrant strsignal() implementations vs. sys_siglist[]
Dec 7, 2015
…ntations vs. sys_siglist[] musl libc does not provide sys_siglist. It does provide a reentrant implementation of strsignal(). Added a cmake build option for using reentrant strsignal() impls instead of sys_siglist. Signed-off-by: John Coyle <dx9err@gmail.com>
dx9
force-pushed
the
wip-12406-sys_siglist
branch
from
December 9, 2015 18:09
4cdf42d
to
82c40b6
Compare
lgtm |
liewegas
added a commit
that referenced
this pull request
Dec 19, 2015
common: signal_handler: added support for using reentrant strsignal() implementations vs. sys_siglist[] Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
signal_handler: added support for using reentrant strsignal() implementations vs. sys_siglist[]
common: signal_handler: added support for using reentrant strsignal() implementations vs. sys_siglist[]
Feb 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @liewegas, I've rebased #6223. Not sure if I was suppose to open a new PR. Cheers