rbd: add --object-size option #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vumrao the relevant part of the bot report is around @@ -206,8 +210,9 @@
rbd help create
usage: rbd create [--pool ] [--image
|
ghost
added
| bool features_specified = false; | ||
|
|
||
| if (vm.count(at::IMAGE_ORDER)) { | ||
| order = vm[at::IMAGE_ORDER].as<uint64_t>(); | ||
| std::cout << "rbd: --order is deprecated, use --object-size" |
There was a problem hiding this comment.
s/cout/cerr/ to match other deprecation warnings
|
looks good, just need to fix the test and one small comment |
vumrao
force-pushed
the
wip-12112-vumrao
branch
from
a613000
to
395cdf0
Compare
|
src/test/cli/rbd/help.t: failed rbd help clone
Again it is failing at same place. Looking into this one. |
vumrao
force-pushed
the
wip-12112-vumrao
branch
2 times, most recently
from
187f081
to
2484b44
Compare
vumrao
force-pushed
the
wip-12112-vumrao
branch
from
2484b44
to
ea4b3c4
Compare
| [--image-shared] [--stripe-unit <stripe-unit>] | ||
| [--order <order>] [--object-size <object-size>] | ||
| [--image-feature <image-feature>] [--image-shared] | ||
| [--stripe-unit <stripe-unit>] | ||
| [--stripe-count <stripe-count>] | ||
| [--journal-splay-width <journal-splay-width>] | ||
| [--journal-object-size <journal-object-size>] | ||
| [--journal-pool <journal-pool>] --size <size> |
There was a problem hiding this comment.
You can remove the withe space change below.
Object size can be specified when creating an image with the --order option, as a number of bits in the size. This patch is adding new option --object-size. This new option will specify object size directly for example --object-size 2M. It would be easier to use. --order is still present for backwards compatibility. For simplicity, we are rounding up the object size to the nearest power of 2. Fixes ceph#12112 Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
vumrao
force-pushed
the
wip-12112-vumrao
branch
from
ea4b3c4
to
71690e7
Compare
|
Can you switch src/test/cli-integration/rbd/defaults.t to use --object-size instead of --order as well? the deprecation message will make it fail otherwise. Nevermind, you did that already. |
jdurgin
added a commit
that referenced
this pull request
Dec 8, 2015
rbd: add --object-size option, deprecate --order Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
@jdurgin Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object size can be specified when creating an image with the --order option,
as a number of bits in the size.
This patch is adding new option --object-size. This new option will specify
object size directly for example --object-size 2M.
It would be easier to use. --order is still present for backwards compatibility.
For simplicity, we are rounding up the object size to the nearest power of 2.
Fixes #12112
Signed-off-by: Vikhyat Umrao vumrao@redhat.com