Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: dev: introduction to tests #6910

Merged
1 commit merged into from Dec 15, 2015
Merged

doc: dev: introduction to tests #6910

1 commit merged into from Dec 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2015

Signed-off-by: Loic Dachary loic@dachary.org

@ghost ghost added the documentation label Dec 13, 2015
@ghost ghost assigned smithfarm Dec 13, 2015
@smithfarm smithfarm assigned ghost and unassigned smithfarm Dec 13, 2015
@ghost ghost assigned smithfarm and unassigned ghost Dec 13, 2015
@ghost
Copy link
Author

ghost commented Dec 13, 2015

Applied your comments and repushed, thanks :-)

@ghost
Copy link
Author

ghost commented Dec 13, 2015

Added a diagram to explain the workflow and its relation to the tests, very high level.

@smithfarm
Copy link
Contributor

And thanks for the whitespace cleanup - the wonders of emacs. . .

@ghost
Copy link
Author

ghost commented Dec 13, 2015

And thanks for the whitespace cleanup - the wonders of emacs. .

The whitespace cleanup is an unintended side effect of the picture mode of emacs which I used to draw ascii :-)

Signed-off-by: Loic Dachary <loic@dachary.org>
@ghost
Copy link
Author

ghost commented Dec 13, 2015

modifications applied & repushed

@ghost
Copy link
Author

ghost commented Dec 15, 2015

@smithfarm would you like me to do some more changes on this pull request ?

@smithfarm
Copy link
Contributor

@dachary No, it looks fine to me now!

Reviewed-by: Nathan Cutler <ncutler@suse.com>

ghost pushed a commit that referenced this pull request Dec 15, 2015
doc: dev: introduction to tests

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@ghost ghost merged commit 9c34d0c into ceph:master Dec 15, 2015
@smithfarm smithfarm assigned ghost and unassigned smithfarm Dec 15, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants