osd: FileStore: conditional collection of drive metadata #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_device_by_uuid->blkid_find_dev_with_tag() call from FileStore::collect_metadata() is hanging for ~3min before returning EINVAL in case the drive is visible but reserved for some other host. This is probably is bug within blkid* calls. fdisk/lsblk call is coming out immediately saying device is inaccessible. This call is now protected by config option filestore_collect_device_partition_information Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
somnathr
referenced
this pull request
in somnathr/ceph
Dec 16, 2015
get_device_by_uuid->blkid_find_dev_with_tag() call from FileStore::collect_metadata() is hanging for ~3min before returning EINVAL in case the drive is visible but reserved for some other host. This is probably is bug within blkid* calls. fdisk/lsblk call is coming out immediately saying device is inaccessible. This call is now protected by config option filestore_collect_device_partition_information Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
|
@liewegas , we are en-counting this issue when the OSD reboot , which take around 7 minutes in the blkid_find* As discussed in ML, seems we don't have much idea why this call block for that long with OSDs didn't prepared via ceph-disk, so a tunable is really necessary for our case. |
liewegas
added a commit
that referenced
this pull request
Dec 17, 2015
…-collection osd: FileStore: conditional collection of drive metadata Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this is part of pull request #6743 .Since that is waiting for Teuthology data , request from Intel came for expediting merge of this commit. Created this pull request so that it can be merged quicker into mainstream.