buffer: fix internal iterator invalidation on rebuild, get_contiguous #6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we rebuild we implicitly invalidate any iterator into the
old list of bufferptrs. Reset the internal last_p iterator to
fix.
The test to reproduce the bug is tricky: we need to get into
a situation where last_p is initialized and p points to
_buffers.begin() (not .end()), e.g.,
bufferlist bl, bl2;
bl2.append("bar");
bl.swap(bl2);
and then rebuild the buffer, so that none of the checks in the
copy_out path reset last_p for some other reason.
Signed-off-by: Sage Weil <sage@redhat.com>
This may modify _buffers. Signed-off-by: Sage Weil <sage@redhat.com>
|
this should get backported |
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Dec 31, 2015
buffer: fix internal iterator invalidation on rebuild, get_contiguous Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.