kv: implement value_as_ptr() and use it in .get() #7052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current .get() methods return values as bufferlists, which are replacing bufferlists provided by caller. This is particularly inefficient with MonitorDBStore, because its get() method uses its own temporary bufferlist which is then appended to bufferlist provided by MonitorDBStore user. This changeset: - adds value_as_ptr() which returns just a bufferptr - modifies *DBStore.get() methods to append returned bufferptr to provided bufferlist instead of replacing it - modifies mondbstore to pass provided bufferlist as target for underlying .get() method, instead of providing its own and appending it to one given by caller. This reduces CPU usage of *DBStore.get() methods by up to 5% (particularly visible with MonitorDBStore, which doesn't use two temporary bufferlists anymore). Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
branch-predictor
force-pushed
the
bp-faster-kv-get
branch
from
6e7c6c6
to
203db29
Compare
… is empty If it's not, data will be appended to the end of bufferlist and difficult to spot bugs might arise, so fail hard in that case. Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
branch-predictor
force-pushed
the
bp-faster-kv-get
branch
from
203db29
to
9b686c3
Compare
liewegas
added a commit
that referenced
this pull request
Jan 6, 2016
kv: implement value_as_ptr() and use it in .get() Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current .get() methods return values as bufferlists, which are replacing
bufferlists provided by caller. This is particularly inefficient with
MonitorDBStore, because its get() method uses its own temporary bufferlist
which is then appended to bufferlist provided by MonitorDBStore user.
This changeset:
bufferlist instead of replacing it
.get() method, instead of providing its own and appending it to one given
by caller.
This reduces CPU usage of *DBStore.get() methods by up to 5% (particularly
visible with MonitorDBStore, which doesn't use two temporary bufferlists
anymore, and for some reason queries mon db store every few seconds).
Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com