hammer: osd: ReplicatedPG: wrong result code checking logic during sparse_read #7179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ahead the result code checking logic before we continue to verify the trailing hole, otherwise the real result of non-hole reading may be overwritten and thus confuse caller. Fixes: #14151 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit b3aa29e) Conflicts: src/osd/ReplicatedPG.cc: trivial resolution
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
…cking logic during sparse_read Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
…cking logic during sparse_read Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-34 for details ) and the upgrade/hammer suite ( see http://tracker.ceph.com/issues/13356#note-37 for details ). |
liewegas
added a commit
that referenced
this pull request
Jan 14, 2016
hammer: ReplicatedPG: wrong result code checking logic during sparse_read Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14287