init-ceph.in: skip ceph-disk if it is not present #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the ceph-mon vs ceph-osd split packaging, users are expected to have the ceph-mon package installed and not ceph-osd (and vice versa). However, the init script (/etc/init.d/ceph) has a call to `ceph-disk`, which may not be present on the machine. Given that our packaging is not yet split upstream, this bug does not manifest itself currently, because both ceph-mon and ceph-disk are currently in the same "ceph" package. Once we split the packaging, though, this will become an issue. http://tracker.ceph.com/issues/10587 Refs: ceph#10587 Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
ktdreyer
force-pushed
the
wip-10587-init-ceph-disk
branch
from
89bed4f
to
7dd9af0
Compare
|
lgtm. |
|
I have some vague recollection that there's some portability problem with running "which" ... but maybe I'm wrong |
liewegas
added a commit
that referenced
this pull request
Feb 24, 2016
init-ceph.in: skip ceph-disk if it is not present Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ceph-mon vs ceph-osd split packaging, users are expected to have the ceph-mon package installed and not ceph-osd (and vice versa). However, the init script (
/etc/init.d/ceph) has a call toceph-disk, which may not be present on the machine.Given that our packaging is not yet split upstream, this bug does not manifest itself currently, because both ceph-mon and ceph-disk are currently in the same "ceph" package. Once we split the packaging, though, this will become an issue.
(This relates to http://tracker.ceph.com/issues/10587 , although it does not implement any actual split in the packaging.)