Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: consider pool size when creating pool #7359

Merged
merged 1 commit into from Mar 17, 2016
Merged

Conversation

songbaisen
Copy link

Mon: When create pool use the crush rule we should consider the pool size

Fixes: #14509
Signed-off-by: song baisen song.baisen@zte.com.cn

@liewegas
Copy link
Member

Can you please add a simple test to one of the scripts in test/ that verifies this works as expected?

@songbaisen
Copy link
Author

@tchaikov Thanks for your reply.I have remove the prefix i.But in our code we like use the prefix like i,f,d,s.m_...

@songbaisen
Copy link
Author

@liewegas Thank you! I will add it later.

@songbaisen
Copy link
Author

@liewegas Hi! I have upload the test script.Please review it.Thandk you!

@liewegas
Copy link
Member

liewegas commented Feb 6, 2016

This doesn't compile.. *ss instead of ss, at least.

Please make sure this builds and passes 'make check'. Thanks!

@songbaisen
Copy link
Author

@liewegas. sorry,It is may be the reason my code is 0.94 not the new node.I have check it ok in 0.94。After the spring day I will do it in the new code.

@songbaisen
Copy link
Author

@liewegas Hi! The ceph code change is really day and night quickly.I have update my code to the new one. @branch-predictor Hi! Do you know why in here this function change '&' to ''.In my eyes use '&' is more better than ''.Thank you!

Fixes: ceph#14509
Signed-off-by: song baisen song.baisen@zte.com.cn
@liewegas liewegas added this to the jewel milestone Mar 9, 2016
@liewegas liewegas changed the title Mon: When create pool use the crush rule we should consider the pool size mon: consider pool size when creating pool Mar 15, 2016
liewegas added a commit that referenced this pull request Mar 17, 2016
mon: consider pool size when creating pool

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit df1e7f8 into ceph:master Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants