Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hammer: rbd: TaskFinisher::cancel should remove event from SafeTimer #7417

Merged
merged 1 commit into from Jan 30, 2016
Merged

hammer: rbd: TaskFinisher::cancel should remove event from SafeTimer #7417

merged 1 commit into from Jan 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2016

@ldachary
rbd: remove canceled tasks from timer thread
46d626d 
When canceling scheduled tasks using the timer thread, TaskFinisher::cancel
does not call SafeTimer::cancel_event, so events fire anyway. Add this call.

Fixes: #14476
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
(cherry picked from commit 2aa0f31)
@ghost ghost self-assigned this Jan 29, 2016
@ghost ghost added this to the hammer milestone Jan 29, 2016
@ghost ghost added bug-fix rbd labels Jan 29, 2016
ghost pushed a commit that referenced this pull request Jan 29, 2016
Merge pull request #7417: hammer: rbd: TaskFinisher::cancel should re…
1ba62b9 
…move event from SafeTimer

Reviewed-by: Loic Dachary <ldachary@redhat.com>
jdurgin added a commit that referenced this pull request Jan 29, 2016
@jdurgin
Merge branch 'wip-14553-hammer' of https://github.com/dachary/ceph in…
71ddde3 
…to wip-hammer-rbd-testing

#7417
jdurgin added a commit that referenced this pull request Jan 30, 2016
@jdurgin
Merge pull request #7417 from dachary/wip-14553-hammer
97d4f6a 
hammer: rbd: TaskFinisher::cancel should remove event from SafeTimer

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
@jdurgin jdurgin merged commit 97d4f6a into ceph:hammer Jan 30, 2016
@renhwztetecs
Copy link
Contributor

@dachary
hi, can you help me to reply:
When will come out 0.94.6 hammer patch version？
thank you

@ghost
Copy link
Author

ghost commented Feb 15, 2016

@renhwztetecs you can follow the progress of v0.94.6 at http://tracker.ceph.com/issues/13356. It is in the latest stages of testing :-) This kind of question are best asked on IRC ( see http://ceph.com/resources/mailing-list-irc/ ).

@ekmixon ekmixon mentioned this pull request Dec 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix rbd
Projects
None yet
Milestone
hammer
2 participants
@renhwztetecs @jdurgin