Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: various fixes from SCA runs #7680

Merged
merged 26 commits into from Feb 24, 2016
Merged

common: various fixes from SCA runs #7680

merged 26 commits into from Feb 24, 2016

Conversation

dalgaaf
Copy link
Contributor

@dalgaaf dalgaaf commented Feb 17, 2016

Several type of fixes:

  • remove unused variables
  • prefer ++operator for non-primitive iterators
  • fix compare same variables with itself
  • change some ctors to explicit
  • fix same variable names in parent and derived class
  • init member variables in constructor
  • remove unused code
  • replace inefficient string::find() w/ compare()
  • reduce scope of variables
  • update .gitignore

@gregsfortytwo
Copy link
Member

Client and MDS patches look fine. Didn't check the others.

@tchaikov
Copy link
Contributor

all commits reviewed. lgtm modulo some nits.

@tchaikov
Copy link
Contributor

lgtm.

@ghost ghost added rgw core cephfs Ceph File System common labels Feb 19, 2016
@dalgaaf
client/Client.cc: reduce scope of some variables
c08435c 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
mds/mdstypes.h: init fnode_t::damage_flags in ctor
aef72ab 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
rgw/rgw_admin.cc: remove unused variables
a5d78c2 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
rgw/rgw_op.cc: remove unused variables
822eecf 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
rgw/rgw_rados.cc: remove unused variable locator
d407faa 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
client/Client.cc: init owner_uid and owner_gid vars in ctor
2b60306 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
client/SyntheticClient.cc: remove unused code
cfd0765 
Removed since 2007 unused code and fixed indentation.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
client/SyntheticClient.cc: reduce scope of some variables
729117f 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
mds/Server.cc: replace inefficient string::find() w/ compare()
8793921 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
cls/rbd/cls_rbd.cc: reuse existing variable with same name
fc44347 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
HTMLFormatter: reuse m_header_done from parent class
44e028f 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
common/Graylog.h: make constructor explicit
b906041 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
common/PluginRegistry.h: init Plugin::library in ctor
11bfc6d 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
test_Replay.cc: prefer ++operator for non-primitive iterators
d71df26 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
journal/JournalMetadata.cc: compare size of lhs instead of rhs to rhs
91a8b1b 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
compressor/zlib/CompressionZlib.cc: reduce scope of variable
6169854 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
compressor/zlib/CompressionPluginZlib.cc: use explicit for ctor
00af2a2 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
ErasureCodeJerasure.h: init packetsize member var in ctor
c51ada3 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
librbd/AioImageRequest.cc: reduce scope of var
60b61b4 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
log/Graylog.h: make ctor explicit
a37ae6a 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
msg/async/Event.cc: reduce scope of variable
e5c9694 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
msg/async/EventKqueue.cc: reduce scope of variable
e6d3a0f 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
librbd/ImageCtx.cc: reduce scope of variable
1f0c1b1 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
librbd/DiffIterate.cc: reduce scope of variable
c645bd9 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
librbd/operation/RebuildObjectMapRequest.cc: init m_snap_list_ret in …
a55f8c2 
…ctor

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
msg/xio/XioConnection.h: init some member variables in ctor
4213b86 
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
Copy link
Contributor Author

dalgaaf commented Feb 19, 2016

rebased, dropped one patch that was already merged with an alternative patch

@tchaikov tchaikov added the rbd label Feb 19, 2016
@dillaman
Copy link

librbd changes lgtm

@liewegas liewegas changed the title Various fixes from SCA runs common: various fixes from SCA runs Feb 24, 2016
liewegas added a commit that referenced this pull request Feb 24, 2016
@liewegas
Merge pull request #7680 from ceph/wip-da-SCA-20160203
4229cd4 
common: various fixes from SCA runs

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <jdillama@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
@liewegas liewegas merged commit 4229cd4 into master Feb 24, 2016
@dalgaaf dalgaaf deleted the wip-da-SCA-20160203 branch April 26, 2016 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix cephfs Ceph File System cleanup common core needs-qa rbd rgw wip-sage-testing
Projects
None yet
Milestone
No milestone
5 participants
@dalgaaf @gregsfortytwo @tchaikov @dillaman @liewegas