osd: filestore: fast abort if statfs encounters ENOENT #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-statfs
branch
from
402911e
to
dfa4c86
Compare
ghost
added
the
| @@ -673,6 +673,8 @@ void OSDService::update_osd_stat(vector<int>& hb_peers) | |||
| int r = osd->store->statfs(&stbuf); | |||
| if (r < 0) { | |||
| derr << "statfs() failed: " << cpp_strerror(r) << dendl; | |||
| osd_stat.hb_in.swap(hb_peers); | |||
| osd_stat.hb_out.clear(); | |||
| return; | |||
There was a problem hiding this comment.
better to just move the block below to before the statfs call
xiexingguo
force-pushed
the
xxg-wip-statfs
branch
from
dfa4c86
to
27ba6ff
Compare
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-statfs
branch
from
27ba6ff
to
e1bc3fe
Compare
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-statfs
branch
from
e1bc3fe
to
46da33b
Compare
|
Fixed |
liewegas
changed the title
liewegas
added a commit
that referenced
this pull request
Mar 1, 2016
osd: filestore: fast abort if statfs encounters ENOENT Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a supplement patch for #6869.
The original case is that if we remove the root directory of an OSD by accident or something alike, and the OSD is currently idle, the OSD process will be able to survive a long time before it does have some consumers to take it down, which may confuse other OSDs and decrease the reliability of the cluster.
This patch try to find out the above case as soon as possible, that is: if statfs to the basedir returned ENOENT, which means the file referred to by path does not exist any more, we abort quickly.
And also for other forgivable errors such as EINTR, we want update heartbeat peers normally.
Verified locally, and below is part of the result: