cmake: fix paths to various EC source files #7748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimaredia
force-pushed
the
wip-cmake-2-22-16
branch
from
5d35848
to
596201b
Compare
| #TODO:build libec_shec_neon library on an ARM machine | ||
| if(ARM_NEON OR ARM_NEON2) | ||
| set(shec_neon_srcs | ||
| ${shec_srcs} |
There was a problem hiding this comment.
shec_srcs can be an OBJECT library to avoid compiling them separately for the ec_shec_generic and ec_shec_neon targets
alimaredia
force-pushed
the
wip-cmake-2-22-16
branch
from
596201b
to
d1d9b16
Compare
| include_directories(.) | ||
| include_directories(${CMAKE_SOURCE_DIR}/src/erasure-code/jerasure/jerasure/include) | ||
| include_directories(${CMAKE_SOURCE_DIR}/src/erasure-code/jerasure/gf-complete/include) | ||
| include_directories(${CMAKE_SOURCE_DIR}/src/erasure-code/jerasure) |
There was a problem hiding this comment.
@cbodley include_directories only applies to targets in a CMakeLists.txt, so I can either leave them as be or put them in erasure-code/CMakeLists.txt
There was a problem hiding this comment.
ok, moving them to erasure-code/CMakeLists.txt sounds better
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
alimaredia
force-pushed
the
wip-cmake-2-22-16
branch
from
d1d9b16
to
cc99072
Compare
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
cbodley
added a commit
that referenced
this pull request
Feb 25, 2016
cmake: fix paths to various EC source files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Benjamin mbenjamin@redhat.com