osd: filestore: restructure journal and op queue throttling #7767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liewegas Does this make sense? |
|
looks good to me, yep! |
athanatos
force-pushed
the
wip-sam-journal-throttle-4
branch
8 times, most recently
from
b26ab08
to
a9ad657
Compare
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Using the throttle here is sketchy, mainly because we won't wake up if something new is queued. Let's do it explicitely. Signed-off-by: Samuel Just <sjust@redhat.com>
The existing FileJournal::throttle_(ops|bytes) throttles overlap with the FileStore op queue throttles. It doesn't seem important whether pending ops are waiting on the journal or the backing fs, so the FileJournal ones are out. Instead, there is now a throttle which is taken in queue_transaction and released in _committed_thru (after sync) which reflects the current fullness of the journal and gradually delays ops as the journal fills up. The intention is to smooth out workloads on small journals. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
athanatos
force-pushed
the
wip-sam-journal-throttle-4
branch
from
a9ad657
to
90d88fd
Compare
|
@athanatos The commit for changing filestore_max_byte to OPT_U64 is missing in this PR |
athanatos
force-pushed
the
wip-sam-journal-throttle-4
branch
from
90d88fd
to
9f4cba3
Compare
Signed-off-by: Samuel Just <sjust@redhat.com>
This is awkward, if there are later users other than this test and JournalingObjectStore, it'll be worth making it a bit less clunky and error prone. Signed-off-by: Samuel Just <sjust@redhat.com>
|
@liewegas Tested and ready for merge. Looks ok? sjust@teuthology:/a/samuelj-2016-02-29_16:00:45-rados-wip-sam-testing-distro-basic-smithi |
liewegas
changed the title
|
lgtm |
athanatos
added a commit
that referenced
this pull request
Mar 1, 2016
osd: filestore: restructure journal and op queue throttling Reviewed-by: Samuel Just <sjust@redhat.com>
|
cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested, see below.