build/ops: RPM: move %post(un) ldconfig calls to ceph-base #7867
Conversation
| @@ -804,7 +804,6 @@ rm -rf $RPM_BUILD_ROOT | |||
|
|
|||
|
|
|||
| %post | |||
There was a problem hiding this comment.
We should probably just rename the (unnamed) %post / %preun / %postun sections to %post base, etc
There was a problem hiding this comment.
@ktdreyer I guess we could do that. I was thinking that the ceph.target systemd service belongs to the ceph package (i.e. to the unnamed %post etc. sections).
There was a problem hiding this comment.
@ktdreyer We are going to have to add systemd code (scriptlets) to the ceph-osd, ceph-mon, and ceph-mds packages , too, at some point.
There was a problem hiding this comment.
The "ceph" RPM should be 100% empty, and the "ceph-base" package should contain ceph.target.
You're right, we should add the systemd scriptlets to the ceph-osd/ceph-mon/ceph-mds packages
There was a problem hiding this comment.
You're right, we should add the systemd scriptlets to the ceph-osd/ceph-mon/ceph-mds packages
Especially since each daemon has its own systemd unit file, now.
This addresses the following RPMLINT error: ceph-base.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libosd_tp.so.1.0.0 ceph-base.x86_64: E: library-without-ldconfig-postun (Badness: 300) /usr/lib64/libos_tp.so.1.0.0 This package contains a library and provides no %postun scriptlet containing a call to ldconfig. ceph-base.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libosd_tp.so.1.0.0 ceph-base.x86_64: E: library-without-ldconfig-postin (Badness: 300) /usr/lib64/libos_tp.so.1.0.0 This package contains a library and provides no %post scriptlet containing a call to ldconfig. http://tracker.ceph.com/issues/14940 Fixes: ceph#14940 Signed-off-by: Nathan Cutler <ncutler@suse.com>
|
@ktdreyer Revised as per your suggestion. I also did some cleanup. |
|
LGTM! @BRANTO1 @alimaredia care to review? |
|
@smithfarm: We should probably re-target this to master. |
|
@BRANTO1 In hindsight I should have landed the packaging split PR in master rather than jewel. Since this PR here fixes some things from the packaging split, I think it's ok to merge it into jewel. |
|
I too would prefer jewel seeing as it's a bugfix. |
|
In that case, we can go ahead and merge it. |
RPM: move %post(un) ldconfig calls to ceph-base Reviewed-by: Ken Dreyer <kdreyer@redhat.com> Reviewed-by: Boris Ranto <branto@redhat.com>
ghost
changed the title
This addresses the following RPMLINT error:
http://tracker.ceph.com/issues/14940 Fixes: #14940
Signed-off-by: Nathan Cutler ncutler@suse.com