New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librbd: allocate new journal tag after acquiring exclusive lock #7884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgtm |
This uuid will be used as the client id for remote peer image journals. This will allow the uuid to be also utilized within the librbd journal tag for tracking epoch ownership. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The mirror peer now holds remote's image id as well as a collection of bootstrap sync points. The tag now contains uuids to map back to the owning pool. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The remote pool name should match the remote pool name. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The journal will not retrieve the tag class for the image within the journal in addition to the most recently allocated tag. Also added helper methods to allocate new tags. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The journal tag tracks a write epoch within the image, so before allowing writes to proceed, ensure the journal entries will be stored under a new epoch. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Now that the tag concept has been re-used for delineating epochs for librbd, we need playback to properly handle the cases where the active playback tag abruptly ends and a newer tag is inserted in the first splay offset object. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
jdurgin
added a commit
that referenced
this pull request
Mar 9, 2016
librbd: allocate new journal tag after acquiring exclusive lock Reviewed-by: Josh Durgin <jdurgin@redhat.com>
jdurgin
added a commit
that referenced
this pull request
Mar 9, 2016
journal: re-use common threads between journalers Conflicts: src/journal/JournalPlayer.cc src/librbd/Journal.cc src/test/rbd_mirror/image_replay.cc src/tools/rbd_mirror/ImageReplayer.h src/tools/rbd_mirror/Mirror.cc (merged interface changes to ImageReplayer, and reduced scope for change to JournalPlayer due to pr #7884 (wip-14663)). Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The journal tags are used to delineate epochs within an image.