New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph.spec.in: do not install Ceph RA on systemd platforms #7894
Conversation
This patch aligns the spec file with src/ocf/Makefile.am, which installs the resource agents in $(prefix)/lib/ocf. Signed-off-by: Nathan Cutler <ncutler@suse.com>
The Ceph Resource Agent (RA) wraps the Ceph init script and is incompatible with systemd. http://tracker.ceph.com/issues/14828 Fixes: ceph#14828 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Continuation of #7810 |
I manually tested this by building in OBS and installing the ceph-resource-agents RPM on openSUSE Tumbleweed. Confirmed that only the RBD RA is installed. |
Looks good to me |
@ktdreyer Who should I ask to review this? The issue it is fixing is as follows: the Ceph Resource Agents are useless on systemd platforms because they wrap |
|
Tore down that run after looking at http://pulpito.ovh.sepia.ceph.com:8081/?branch=jewel and seeing that it would be affected by http://tracker.ceph.com/issues/15123 which is fixed by #8073 Rolled a new wip branch including the fix for this issue. New upgrade/infernalis-x run in OVH:
|
lgtm in principle; feel free to merge once you're satisfied with the testing. |
@dachary This passed the Do you think that is sufficient to demonstrate that it doesn't break anything? |
ceph.spec.in: do not install Ceph RA on systemd platforms Reviewed-by: Tim Serong <tserong@suse.com> Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Loic Dachary <ldachary@redhat.com>
The ceph-resource-agents package consists of two RAs: the "Ceph RA" (which includes RAs for OSD, MON, and MDS) and the "RBD RA". Since the Ceph RA wraps the Ceph sysvinit script, it cannot be used on systemd-based platforms. The RBD RA is OK on systemd.
http://tracker.ceph.com/issues/14828 Fixes: #14828