crush: update tunable docs. change default profile to jewel. #7964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
| Over time, we have made (and continue to make) improvements to the | ||
| CRUSH algorithm used to calculate the placement of data. In order to | ||
| support the change in behavior, we have introduced a series of tunable | ||
| options that control whether the legacy or improved variatio of the |
liewegas
force-pushed
the
wip-crush-jewel
branch
from
9abc231
to
2839fd1
Compare
- break it down by tunable profile - explicitly call out the migration impact for each profile jump. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Since we do not set this when we set tunables, we should not check it when we report which tunables they have set. For example, a savvy operator on firefly tunables should set straw_calc_version to 1 but we still want the cluster to report that they are on firefly tunables. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-crush-jewel
branch
from
2839fd1
to
b323997
Compare
|
@jecluis @athanatos will review |
|
Ah, the min check relies on the fact that we've been choosing version names such that newer ones sort higher. lgtm |
This mimics the feature bit enforcement in OSDMap.cc but it does it based on the version string. This is useful when you have CRUSH tunables that aren't mapped to a named profile. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-crush-jewel
branch
from
b323997
to
1e4de96
Compare
If they cluster is using very old tunables, as inferred by whether it requires a newer version of CRUSH, issue a health warning. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-crush-jewel
branch
from
1e4de96
to
9e83f5b
Compare
liewegas
added a commit
that referenced
this pull request
Mar 14, 2016
crush: update tunable docs. change default profile to jewel Reviewed-by: Samuel Just <sjust@redhat.com>
|
Make check gitbuilder has been failing since this PR merged (http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-tarball-trusty-amd64-basic/log.cgi?log=203d604d7221ac3bb721a39efff72f2f0dbb1193) — it looks to me like it's just expected output changes as a result of changing the CRUSH defaults, but definitely needs to be updated! |
|
@gregsfortytwo seems sage has already a PR (#8107) addressing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.