mon/PGMonitor: reliably mark PGs state #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov mind taking a look? |
|
I'm trying to track down a bug where the mon marked every pg stale but I can't figure out why.. the extra debugging here will help a bit. |
In beb99d7 we partially addressed the case where a acting_primary update raced with an attemp to mark the pg state. However, if the acting_primary changed, we didn't check the new acting_primary to ensure that it is also down and we should still mark things stale. Also, printing out the acting_primary aids debugging. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-mark-pg-stale
branch
from
0c8e64a
to
26d4f2e
Compare
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Mar 15, 2016
mon/PGMonitor: reliably mark PGs state Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In beb99d7 we partially addressed
the case where a acting_primary update raced with an attemp to
mark the pg state. However, if the acting_primary changed, we
didn't check the new acting_primary to ensure that it is also
down and we should still mark things stale.
Also, printing out the acting_primary aids debugging.
Signed-off-by: Sage Weil sage@redhat.com