osd: filestore: fix race condition with split vs collection_move_rename and long object names #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Just <sjust@redhat.com>
See comment for explanation. Signed-off-by: Samuel Just <sjust@redhat.com>
If the file has an alt attr, there are two possible matching ghobjects. We want to make sure we choose the right one for the short name we have. If we don't, a split while there are two objects linking to the same inode will result in one of the links being orphaned in the source directory, resulting in ceph#14766. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
1/2 of objects will now have long names, and we'll shift the region of the hash space where new objects are created every 1024 objects created. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
liewegas
changed the title
liewegas
changed the title
liewegas
added a commit
that referenced
this pull request
Mar 15, 2016
osd: filestore: fix race condition with split vs collection_move_rename and long object names Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in lfn_translate which can cause a split during collection_move_rename to orphan a dummy file confusing scrub and collection removal.
http://tracker.ceph.com/issues/14766
Tested: sjust@teuthology:/a/samuelj-2016-03-14_17:37:24-rados-wip-sam-testing-distro-basic-smithi