Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgw ldap fixes #8168

Merged
merged 2 commits into from Mar 16, 2016
Merged

Rgw ldap fixes #8168

merged 2 commits into from Mar 16, 2016

Conversation

mattbenjamin
Copy link
Contributor

No description provided.

The parameter really is dnattr (attribute used to form DNs), not
memberattr (attribute used to form group member strings).

Switch to the correct name for this attribute, to avoid confusion--
especially if we ever apply group membership checks in future.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@mattbenjamin mattbenjamin added this to the jewel milestone Mar 16, 2016
@@ -92,6 +91,10 @@ librgw_la_SOURCES = \
rgw/rgw_xml_enc.cc \
rgw/rgw_website.cc

if WITH_OPENLDAP
librgw_la_SOURCES += rgw/rgw_ldap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattbenjamin rgw/rgw_ldap.cc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yehudasa er, yeah

(it works as is because rgw_ldap.cc has no text--but I left it in place for future)

repushed

Permit building without LDAP support--support is enabled by default.
Tested with CMake and autotools standalone builds.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
yehudasa added a commit that referenced this pull request Mar 16, 2016
Rgw ldap fixes

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
@yehudasa yehudasa merged commit 7789e18 into ceph:master Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants