systemd: set up environment in rbdmap unit file

[smithfarm]

http://tracker.ceph.com/issues/14984 Fixes: #14984

Signed-off-by: Nathan Cutler ncutler@suse.com

[smithfarm]

The bug report says "/usr/bin/rbdmap requires the RBDMAPFILE variable to be set," which doesn't sound right. Shouldn't the code default to a sensible value if the environment variable is not set?

[smithfarm]

@tchaikov @BRANTO1 Your thoughts?

[smithfarm]

I looked in qa/workunits/ but did not see any obvious evidence that tests are exercising rbdmap. Anyone know which suite I should run to test this?

[smithfarm]

Spawning a cluster for manual testing with: cw ceph-qa-suite --simultaneous-jobs 9 --verbose --teuthology-git-url http://github.com/dachary/teuthology --teuthology-branch openstack --ceph-qa-suite-git-url http://github.com/dachary/ceph-qa-suite --suite-branch wip-ceph-disk --ceph-git-url http://github.com/SUSE/ceph --ceph wip-14984 --suite ceph-disk --filter centos_7

(See #8228 for an explanation of how this works.)

[smithfarm]

Scope of test: on the cluster deployed with packages built from this PR, run systemctl start rbdmap.service and inspect the logs for bogus messages. Confirm there are none. Add set -x to /usr/bin/rbdmap and restart the service. Confirm via journalctl that the /etc/ceph/rbdmap file is processed. Then, back out the changes and restart the service again - confirm that bogus messages appear in the log and /etc/ceph/rbdmap file is not processed.

The test did not include creating an RBD image or using rbdmap to map it to a device and mount it.

Test result: passed

[smithfarm]

Cherry-picked 0effb9e (the commit containing the new workunit) to jewel-wip-workunit branch based on jewel.

Running the workunit as a standalone test against this modified jewel branch to demonstrate that the workunit fails (for the right reason) when the bug is present.

failed for the right reason http://149.202.177.104:8081/ubuntu-2016-03-20_23:45:18-rbd:singleton:all:rbdmap_RBDMAPFILE.yaml-jewel-wip-workunit---basic-openstack/

2016-03-21T00:43:41.510 INFO:tasks.workunit.client.0.target149202177065.stdout:TEST: assert that rbdmap has not logged anything since TIMESTAMP
2016-03-21T00:43:41.511 INFO:tasks.workunit.client.0.target149202177065.stderr:+ echo 'TEST: assert that rbdmap has not logged anything since TIMESTAMP'
2016-03-21T00:43:41.511 INFO:tasks.workunit.client.0.target149202177065.stderr:+ grep 'rbdmap\[[[:digit:]]'
2016-03-21T00:43:41.511 INFO:tasks.workunit.client.0.target149202177065.stderr:+ journalctl --since '2016-03-21 00:43:41' -t rbdmap
2016-03-21T00:43:41.513 INFO:tasks.workunit.client.0.target149202177065.stderr:+ journalctl --since '2016-03-21 00:43:41' -t init-rbdmap
2016-03-21T00:43:41.514 INFO:tasks.workunit.client.0.target149202177065.stderr:+ grep 'rbdmap\[[[:digit:]]'
2016-03-21T00:43:41.515 INFO:tasks.workunit.client.0.target149202177065.stdout:Mar 21 00:43:41 target149202177065.teuthology init-rbdmap[16871]: No  found.
2016-03-21T00:43:41.516 INFO:tasks.workunit.client.0.target149202177065.stderr:+ exit 1
2016-03-21T00:43:41.516 DEBUG:paramiko.transport:[chan 38] EOF received (38)
2016-03-21T00:43:41.517 INFO:tasks.workunit:Stopping ['rbd/test_rbdmap_RBDMAPFILE.sh'] on client.0...

Command used: cw ceph-qa-suite --simultaneous-jobs 9 --verbose --teuthology-git-url http://github.com/dachary/teuthology --teuthology-branch openstack --ceph-qa-suite-git-url http://github.com/smithfarm/ceph-qa-suite --suite-branch wip-14984 --ceph-git-url https://github.com/SUSE/ceph --ceph jewel-wip-workunit --suite rbd/singleton/all/rbdmap_RBDMAPFILE.yaml distros/all/centos_7.2.yaml

[smithfarm]

Running the workunit as a standalone test against this PR to validate the bugfix.

pass http://149.202.177.104:8081/ubuntu-2016-03-21_05:50:38-rbd:singleton:all:rbdmap_RBDMAPFILE.yaml-wip-14984---basic-openstack/

2016-03-21 06:49:09,277.277 INFO:tasks.workunit.client.0.target149202181028.stdout:TEST: assert that rbdmap has not logged anything since TIMESTAMP
2016-03-21 06:49:09,278.278 INFO:tasks.workunit.client.0.target149202181028.stderr:+ echo 'TEST: assert that rbdmap has not logged anything since TIMESTAMP'
2016-03-21 06:49:09,278.278 INFO:tasks.workunit.client.0.target149202181028.stderr:+ journalctl --since '2016-03-21 06:49:09' -t rbdmap
2016-03-21 06:49:09,279.279 INFO:tasks.workunit.client.0.target149202181028.stderr:+ grep 'rbdmap\[[[:digit:]]'
2016-03-21 06:49:09,279.279 INFO:tasks.workunit.client.0.target149202181028.stderr:+ journalctl --since '2016-03-21 06:49:09' -t init-rbdmap
2016-03-21 06:49:09,280.280 INFO:tasks.workunit.client.0.target149202181028.stderr:+ grep 'rbdmap\[[[:digit:]]'
2016-03-21 06:49:09,281.281 DEBUG:paramiko.transport:[chan 38] EOF received (38)
2016-03-21 06:49:09,282.282 INFO:tasks.workunit.client.0.target149202181028.stderr:+ exit 0
...
2016-03-21 06:49:57,152.152 INFO:teuthology.run:Summary data:
{description: 'rbd:singleton:all:rbdmap_RBDMAPFILE.yaml', duration: 597.1750349998474,
  flavor: basic, owner: scheduled_ubuntu@teuthology, success: true}

cw ceph-qa-suite --simultaneous-jobs 9 --verbose --teuthology-git-url http://github.com/dachary/teuthology --teuthology-branch openstack --ceph-qa-suite-git-url http://github.com/smithfarm/ceph-qa-suite --suite-branch wip-14984 --ceph-git-url https://github.com/SUSE/ceph --ceph wip-14984 --suite rbd/singleton/all/rbdmap_RBDMAPFILE.yaml distros/all/centos_7.2.yaml

[smithfarm]

Associated ceph/ceph-qa-suite PR: ceph/ceph-qa-suite#902

[smithfarm]

here we could add a packaging test that would check which rbdmap (just to verify that the shell script is packaged)

[b-ranto]

lgtm

[smithfarm]

@BRANTO1 Thanks for the review! Could you take a look at #8224 as well?