Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbdmap: add manpage #8224

Merged
merged 2 commits into from Mar 24, 2016
Merged

rbdmap: add manpage #8224

merged 2 commits into from Mar 24, 2016

Conversation

smithfarm
Copy link
Contributor

http://tracker.ceph.com/issues/15212 Fixes: #15212

Signed-off-by: Nathan Cutler ncutler@suse.com

http://tracker.ceph.com/issues/15212 Fixes: ceph#15212

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm force-pushed the wip-15212 branch 3 times, most recently from 8f08e69 to e1841a9 Compare March 19, 2016 21:06
@smithfarm smithfarm added this to the jewel milestone Mar 21, 2016
========

| **rbdmap**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the basic usage info, here. I.e. rbdmap map | unmap.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

While it is true that it is usually run by init system, a user can also easily run it to achieve the same thing without having to have it run every time a computer starts -- that is why I originally kept it as a script in /usr/bin.

Alternatively, we could skip creating the man page altogether and move the script to /usr/lib/... (libexecdir). I'm not sure how useful the standalone script in bindir is and it depends mostly on that.

If there is a reasonable use case for running it manually (and I think there is), we should keep it where it is. I revamped the manpage a little - can you take another look?

@b-ranto
Copy link
Contributor

b-ranto commented Mar 23, 2016

I also think there is a valid use case for this being in bindir (well, that is why I originally put it there). With the recent changes to the wording and after mentioning map/unmap in the man page, lgtm,

@jdurgin jdurgin merged commit 20c8650 into ceph:master Mar 24, 2016
@smithfarm smithfarm deleted the wip-15212 branch January 7, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants