cmake: fix mrun to handle cmake build structure #8237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oritwas
force-pushed
the
wip-rgw-fix-mrun
branch
from
cbdd317
to
b79abb9
Compare
|
@cbodley I pushed a newer version that handles the conf file too |
| CEPH_CONF_PATH=$root/run/$run_name | ||
|
|
||
| if [ -e CMakeCache.txt ]; then | ||
| CEPH_BIN=$PWD/src |
There was a problem hiding this comment.
note that this bit is going to change to $PWD/bin once @alimaredia's cmake check work (#7912) gets merged
|
thanks @oritwas! for my multisite testing, I had been hacking around this with symlinks. after removing those and testing this pr, there are still a couple issues running ceph/src/test/rgw/test_multi.py. but I'll add fixes for those in a separate pull request - this one looks good 👍 |
|
see #8246 for the related multisite test fixes |
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
oritwas
force-pushed
the
wip-rgw-fix-mrun
branch
from
b79abb9
to
14dc847
Compare
|
@cbodley removed the -x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Orit Wasserman owasserm@redhat.com