vstart: make -k with optional mon_num. #8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -275,6 +275,13 @@ esac | |||
| shift | |||
| done | |||
|
|
|||
| if [ "$overwrite_conf" -eq 0 ]; then | |||
| CEPH_NUM_MON=`cat $conf_fn|grep CEPH_NUM_MON|awk -F= '{print $2}'` | |||
There was a problem hiding this comment.
nit, could just put
CEPH_NUM_MON=`awk -F= '/CEPH_NUM_MON/{print $2}' $conf_fn`
|
lgtm apart from a nit. |
majianpeng
force-pushed
the
vstart
branch
2 times, most recently
from
6b94882
to
81fa2ca
Compare
Default mon_num=3, if we change this and using -k to create a new cluster. It don't work. So we must record the old mon_num. The same for osd_num/mds_num/rgw_num. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
|
This PR now causes
|
| @@ -275,6 +275,13 @@ esac | |||
| shift | |||
| done | |||
|
|
|||
| if [ "$overwrite_conf" -eq 0 ]; then | |||
| CEPH_NUM_MON=`awk -F= '/CEPH_NUM_MON/{print $2}' $conf_fn` | |||
There was a problem hiding this comment.
Can we default these if the awk fails?
There was a problem hiding this comment.
ahh, sorry, i overlooked this. will fix it tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default mon_num=3, if we change this and using -k to create a new
cluster. It don't work. So we must record the old mon_num.
The same for osd_num/mds_num/rgw_num.
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com