monclient: avoid key renew storm on clock skew #8258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refreshing rotating keys too often is a symptom of a clock skew, try to
detect it and don't cause extra problems:
* MonClient::_check_auth_rotating:
- detect and report premature keys expiration due to a time skew
- rate limit refreshing the keys to avoid excessive RAM and CPU usage
(both by OSD in question and monitors which have to process a lot
of auth messages)
* MonClient::wait_auth_rotating: wait for valid (not expired) keys
* OSD::init(): bail out after 10 attempts to obtain the rotating keys
Fixes: ceph#12065
Signed-off-by: Alexey Sheplyakov <asheplyakov@mirantis.com>
| @@ -840,9 +844,22 @@ int MonClient::_check_auth_rotating() | |||
| } | |||
|
|
|||
| ldout(cct, 10) << "_check_auth_rotating renewing rotating keys (they expired before " << cutoff << ")" << dendl; | |||
| if (!rotating_secrets->need_new_secrets() && | |||
| rotating_secrets->need_new_secrets(issued_at_lower_bound)) { | |||
There was a problem hiding this comment.
need_new_secrets is
bool need_new_secrets(utime_t now) const {
return secrets.size() < KEY_ROTATE_NUM || current().expiration <= now;
}
and issued_at_lower_bound is before now.. when will this ever be true?
There was a problem hiding this comment.
If the client (OSD) system clock is off by a few hours (in the future) with respect to monitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshing rotating keys too often is a symptom of a clock skew, try to
detect it and don't cause extra problems:
(both by OSD in question and monitors which have to process a lot
of auth messages)
Fixes: #12065
Signed-off-by: Alexey Sheplyakov asheplyakov@mirantis.com