doc: amend Fixes instructions in SubmittingPatches #8312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the "Fixes: #..." line is interpreted by GitHub as referring to a pull request, yet the intention is for it to refer to the tracker issue, change our instructions to use the full tracker issue URL. Now that github pull request numbers are in the 8000s, there are cases when a PR is wrongly closed by a "Fixes: #..." line in a commit message. See ceph#8286 (comment) for one such case. Signed-off-by: Nathan Cutler <ncutler@suse.com>
|
👍 but giving it time for other people to voice concerns |
|
👍 |
|
👍 seems like this should be noted on ceph-devel for more visibility too |
|
@jdurgin Done |
ghost
merged commit 
ghost
self-assigned this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the "Fixes: #..." line is interpreted by GitHub as referring to a
pull request, yet the intention is for it to refer to the tracker issue,
change our instructions to use the full tracker issue URL.
Now that github pull request numbers are in the 8000s, there are cases when
a PR is wrongly closed by a "Fixes: #..." line in a commit message. See
#8286 (comment)
for one such case.
Signed-off-by: Nathan Cutler ncutler@suse.com