rgw: RGWPeriod::reflect() sets master zonegroup as default #8566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
force-pushed
the
wip-rgw-period-reflect
branch
from
75d35f1
to
09a4cd4
Compare
cbodley
changed the title
| @@ -1204,6 +1204,8 @@ int RGWPeriod::reflect() | |||
| ldout(cct, 0) << "ERROR: failed to store zonegroup info for zonegroup=" << iter.first << ": " << cpp_strerror(-r) << dendl; | |||
| return r; | |||
| } | |||
| // set as default if no default exists | |||
| zg.set_as_default(true); | |||
There was a problem hiding this comment.
I think it is better to set the master zonegroup as default and not the first.
There was a problem hiding this comment.
sure. i think i'll also add a ldout message if it successfully changes the default
if RGWPeriod::reflect() is called right after a 'realm pull', it will create the zonegroup objects but not set any as default. so the next time RGWRados is initialized, create_defaults() will add a new 'default' zonegroup and set it as the master. this causes a 'period update' to find multiple master zonegroups and fail with EINVAL reflect() now calls set_as_default(exclusive=true) on the master zonegroup to guarantee that a default is set Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley
force-pushed
the
wip-rgw-period-reflect
branch
from
09a4cd4
to
5230967
Compare
cbodley
changed the title
|
@oritwas updated to only call set_as_default() on master zg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the configuration of a secondary cluster by establishing a default zonegroup after the initial 'realm pull'.
Previously, the initial output of 'zonegroup list' was:
With these patches, the output is as expected: