mailmap: Abhishek Lekshmanan affiliation #8615
Conversation
| @@ -9,6 +9,7 @@ | |||
| Aaron Bassett <abassett@gmail.com> | |||
| Abhishek Lekshmanan <abhishek.lekshmanan@ril.com> <abhishek.lekshmanan@gmail.com> | |||
There was a problem hiding this comment.
this one should then be removed, right ?
There was a problem hiding this comment.
I'm not sure, without removing it also, if do the credits.sh script from prev release I'm getting the correct output?
There was a problem hiding this comment.
In any case only one of them will be taken into account. There is no way to resolve this so that past contributions stay with the previous mapping. There would need to be a time range for which a mailmap entry is valid, but that's not supported. In other words, unless you change your personal email, contributions from the past will be remapped incorrectly when using a recent .mailmap. There always is the option of using the former .mailmap to get the correct affiliation, which is probably the right thing to do.
There was a problem hiding this comment.
Ah ok, what is to be done here then, I'm ok with closing this. not that much of a deal, anyway most of the commits dont use this email id, only the reviewed-by since that is added by the dev. doing the merge. (for eg. in 10.1.2 contributor credits it appeared in reviewed-by mostly)
There was a problem hiding this comment.
I think it would make sense to remove the
Abhishek Lekshmanan <abhishek.lekshmanan@ril.com> <abhishek.lekshmanan@gmail.com>
line.
Adding an entry to normalize the personal email id and work email id Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
force-pushed
the
fix-mailmap-self
branch
from
a240550
to
c4b7a25
Compare
|
@dachary updated as you suggested |
ghost
merged commit 
Adding an entry to normalize the personal email id and work email id (As reviews/and commits assoc'ed with gmail still got normalized to previous email)