hammer: osd: is_split crash in handle_pg_create #8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we have a wrong "created", OSD receiving an osd_pg_create message could fail to project its history and crash. a bad split_bits could mislead the monitor and osd, and hence cause problems. * set child.info.history.epoch_created to osdmap.get_epoch() instead of using the parent's epoch_created * set child.info.stats.parent_split_bits to the calculated split_bits instead using the parent's split_bits Fixes: http://tracker.ceph.com/issues/15426 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 8b98556)
smithfarm
added a commit
that referenced
this pull request
Jun 1, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jun 27, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 18, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 24, 2016
Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@tchaikov This PR is in the latest round of hammer-backports integration tests, which passed a rados run (the only failures are a valgrind false positive that has since been fixed by ceph/teuthology#915 and http://tracker.ceph.com/issues/15139 which is an infrastructure issue with two of the tests) - for details, see: http://tracker.ceph.com/issues/15895#note-18 Do you think this PR is OK to merge? |
|
@tchaikov This PR passed a /200 rados run on Ubuntu. None of the failures were reproducible. For details see http://tracker.ceph.com/issues/15895#note-18 Do you think it's OK to merge? |
|
@tchaikov @athanatos OK to merge? |
|
I'm ok with it if @tchaikov is. |
|
@smithfarm sorry for the latency! lgtm |
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15482