jewel: rgw: segfault at RGWAsyncGetSystemObj #9017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the mtime of the object that was removed in the bucket index log. This will be used in data sync. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 80d6404)
If we know that the object does not exist, no need to remove it. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 8d59a30)
Fixes: ceph#15565 check only verified that status was > 0, so we ended not updating mtime for the target object. This resulted in a continuous sync of objects. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 255f19d)
Fixes: http://tracker.ceph.com/issues/15625 The async read data/attrs coroutines may outlive the callers. Instead of introducing a complicated refcounting scheme, just don't pass it in. Anyway, it was not thread safe, and the benefit of using it is not clear. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit b225d17)
Otherwise we're going to busy loop there. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 806fb85)
We used to allow concurrent requests, as long as these had different op, which wasn't correct. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit edea6d5)
ghost
assigned
ghost
pushed a commit
that referenced
this pull request
May 10, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
May 10, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
test this please |
|
pass http://pulpito.ceph.com/yehudasa-2016-05-09_22:10:04-rgw-wip-rgw-jewel---basic-smithi/ (failures can be ignored) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15802