jewel: rgw: leak fixes #9022
Merged
jewel: rgw: leak fixes #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 4442d1c)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit cb797d4)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit a3a3f4f)
init can be called more than once, ended up with leaking some resources Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 14cd44e)
was missing destructor, constructor was broken Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 95162a4)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit d1ec31d)
destructor calls stop(), but it can be also called explicitly, if caller wants to ensure requests are not being handled anymore. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit bdce81a)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 98433e5)
pe->store might change when reconfiguring Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 2ca38da)
this is past calling req_data->finish(), client can be destroyed by now Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 7ada4df)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 1c876eb)
call sync_env.init() even if we're initalized in RGWRemoteDataLog::init() Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 3d8442e)
No need to wait for req_state to complete anymore. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 91f61d6) Conflicts: src/rgw/rgw_http_client.cc
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
May 10, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
May 10, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15794