Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: osd: add peer_addr in heartbeat_check log message #9739

Merged
2 commits merged into from Oct 10, 2016
Merged

jewel: osd: add peer_addr in heartbeat_check log message #9739

2 commits merged into from Oct 10, 2016

Conversation

vumrao
Copy link
Contributor

@vumrao vumrao commented Jun 16, 2016

osd: add peer_addr in heartbeat_check log message

Fixes: http://tracker.ceph.com/issues/16337

Signed-off-by: Vikhyat Umrao vumrao@redhat.com
(cherry picked from commit f235b9c)

@vumrao
osd: add peer_addr in heartbeat_check log message
d5c77c8 
Fixes: http://tracker.ceph.com/issues/16337

Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
(cherry picked from commit f235b9c)
@vumrao
Copy link
Contributor Author

vumrao commented Jun 16, 2016

looking into this one , looks like jewel has change in structure as compare to master :

osd/OSD.cc: In member function ‘void OSD::heartbeat_check()’:
osd/OSD.cc:4066:538: error: ‘const struct entity_addr_t’ has no member named ‘get_sockaddr’
  derr << "heartbeat_check: no reply from " << p->second.con_front->get_peer_addr().get_sockaddr()
osd/OSD.cc:4072:538: error: ‘const struct entity_addr_t’ has no member named ‘get_sockaddr’
  derr << "heartbeat_check: no reply from " << p->second.con_front->get_peer_addr().get_sockaddr()

@vumrao vumrao changed the title osd: add peer_addr in heartbeat_check log message jewel : osd: add peer_addr in heartbeat_check log message Jun 16, 2016
@liewegas @vumrao
msg/msg_types: update sockaddr, sockaddr_storage accessors
47605a2 
Return sockaddr_storage by value.  New sockaddr-based accessors.

Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
(cherry picked from commit 0038d36)
@vumrao
Copy link
Contributor Author

vumrao commented Jun 16, 2016

  • Thank you @badone for helping me to finding out the commit which has introduced get_sockaddr().
  • For this backport commit 0038d36 is needed.

@dillaman dillaman added this to the jewel milestone Jun 17, 2016
@dillaman dillaman added the core label Jun 17, 2016
@ghost ghost self-assigned this Jun 29, 2016
ghost pushed a commit that referenced this pull request Jun 30, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
43c268b 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Jul 1, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
016d81e 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Aug 4, 2016

@liewegas does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-13

@ghost ghost assigned liewegas Aug 4, 2016
ghost pushed a commit that referenced this pull request Aug 8, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
3c88755 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 9, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
47d2e93 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 12, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
78c525d 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Aug 15, 2016

@liewegas ping

ghost pushed a commit that referenced this pull request Aug 16, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
f83c805 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 17, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
5ed9bc7 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 22, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
d9525b2 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 22, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
2400c91 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 23, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
9cb6d04 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 24, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
d3cdbab 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 24, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
85fcc35 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 24, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
680ecfa 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 24, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
201142d 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 24, 2016
Merge pull request #9739: jewel : osd: add peer_addr in heartbeat_che…
0a861b4 
…ck log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title jewel : osd: add peer_addr in heartbeat_check log message jewel: osd: add peer_addr in heartbeat_check log message Aug 25, 2016
@ghost
Copy link

ghost commented Aug 25, 2016

@liewegas ping

ghost pushed a commit that referenced this pull request Aug 25, 2016
Merge pull request #9739: jewel: osd: add peer_addr in heartbeat_chec…
2e5e3e2 
…k log message

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@athanatos
Copy link
Contributor

@dachary Looks fine for backport to me.

@ghost ghost merged commit 8a84877 into ceph:jewel Oct 10, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liewegas liewegas

Labels
core
Projects
None yet
Milestone
jewel
4 participants
@vumrao @athanatos @liewegas @dillaman