Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LCM configuration recipes. #57

Closed

Conversation

Aliasgar16
Copy link

In-progress.

…by Foodcritic and Rubocop for the same recipes.
@@ -4,7 +4,7 @@
license 'Apache 2.0'
description 'Installs/Configures PowerShell on the Windows platform'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version '3.1.0'
version '3.2.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamedx, please comment is the version looks ok.

@NimishaS
Copy link

NimishaS commented Oct 7, 2015

disable_lcm recipe requires powershell 5 to be installed for supporting Refreshmode=Disabled. Hence we have included powershell 5 recipe in disable_lcm.
In case user's current powershell version is less than 5, then powershell 5 is installed and the system gets rebooted. Then user need to run the disable_lcm recipe again. We should mention this in Readme. This should be done in another PR.

@adamedx
Copy link

adamedx commented Oct 7, 2015

@smurawski thoughts on this pr? This is to allow users to configure the lcm.

@smurawski
Copy link
Contributor

Thanks! I grabbed some commits and tweaked a bit of this. I'll be getting this merged early next week.

smurawski added a commit that referenced this pull request Dec 11, 2015
@smurawski
Copy link
Contributor

Merged as part of #63

@smurawski smurawski closed this Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants